feat: use best practices, add tests, fixes #8#9
Merged
ygerasimov merged 1 commit intoDiffyWebsite:mainfrom Feb 27, 2026
Merged
Conversation
Contributor
Author
|
Warning This PR adds
|
Contributor
|
@stasadev thank you very much for doing all this. I have disabled and re-enabled this workflow. Hope you won't be getting email notifications. |
Contributor
Author
|
A new release is also needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Issue
How This PR Solves The Issue
See https://ddev.com/blog/ddev-add-on-maintenance-guide/#recommendations-for-add-on-maintainers
This PR:
curl -fsSL https://ddev.com/s/addon-update-checker.sh | bashddev screenshotworks, but perform different checks.ddev/diffy-worker/.envwhen the add-on is reinstalled$DDEV_HOSTNAMEinddev screenshotto${DDEV_SITENAME}.${DDEV_TLD}(because DDEV_HOSTNAME can look liketest.ddev.site,extra.ddev.site,one-more.ddev.sitewhen you haveadditional_hostnames)P.S. the tests can be improved later to see if the
ddev screenshotreally works.Manual Testing Instructions
Review https://github.com/stasadev/ddev-diffy/blob/20260226_stasadev_diffy/README.md
Automated Testing Overview
Release/Deployment Notes